Make libphutil `utils.php` PHP version violations statically analyzable
ClosedPublic
Actions

Authored by epriestley on Feb 11 2019, 10:21 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13249: 2019 Week 7 - 10 Bonus Content

Commits

rPHUa7c995a2327f: Make libphutil `utils.php` PHP version violations statically analyzable

Summary

Ref T13249. We actually already have a function_exists() check.

We don't have a constant() check, but the next change will add one.

Test Plan

Ran unit tests. No more lint warnings.

Diff Detail

Repository

rPHU libphutil

Branch

lint1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21930
Build 29947: Run Core Tests
Build 29946: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 11 2019, 10:21 PM

Harbormaster completed remote builds in B21930: Diff 48091.Feb 11 2019, 10:21 PM

epriestley requested review of this revision.Feb 11 2019, 10:21 PM

epriestley mentioned this in D20146: Add version check whitelists for constants to the version compatibility lint rule.Feb 11 2019, 10:25 PM

amckinley accepted this revision.Feb 11 2019, 11:09 PM

This revision is now accepted and ready to land.Feb 11 2019, 11:09 PM

Closed by commit rPHUa7c995a2327f: Make libphutil `utils.php` PHP version violations statically analyzable (authored by epriestley). · Explain WhyFeb 11 2019, 11:20 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rARC7e61e43f6554: Add version check whitelists for constants to the version compatibility lint….Feb 12 2019, 1:19 PM

Revision Contents
Changeset List

Path

Size

src/

utils/

utils.php

12 lines

Diff 48091

View Options

Make libphutil `utils.php` PHP version violations statically analyzableClosedPublicActions