Page MenuHomePhabricator

When building audit queries, prefilter possible "authorPHID" values
ClosedPublic

Authored by epriestley on Feb 7 2019, 7:54 PM.
Tags
None
Referenced Files
F13096084: D20129.diff
Thu, Apr 25, 2:22 PM
Unknown Object (File)
Sat, Apr 20, 4:33 PM
Unknown Object (File)
Wed, Apr 17, 3:07 PM
Unknown Object (File)
Thu, Apr 11, 7:16 AM
Unknown Object (File)
Fri, Apr 5, 10:39 PM
Unknown Object (File)
Mon, Apr 1, 7:37 PM
Unknown Object (File)
Fri, Mar 29, 8:19 PM
Unknown Object (File)
Mar 26 2024, 1:28 PM
Subscribers
None

Details

Summary

Ref T13244. See PHI1057. Currently, if you're a member of a lot of projects/packages, you can end up with a very large commit.authorPHID IN (...) clause in part of the "Active Audits" query, since your alice token in "Responsible Users: alice" expands into every package and project you can audit on behalf of.

It's impossible for a commit to be authored by anything but a user, and evidence in PHI1057 suggests this giant IN (...) list can prevent MySQL from making effective utilization of the <authorPHID, auditStatus, ...> key on the table.

Prefilter the list of PHIDs to only PHIDs which can possibly author a commit.

(We'll also eventually need to convert the authorPHIDs into identityPHIDs anyway, for T12164, and this moves us slightly toward that.)

Test Plan

Loaded "Active Audits" before and after change, saw a more streamlined and sensible authorPHID IN (...) clause afterwards.

Diff Detail

Repository
rP Phabricator
Branch
audit4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21886
Build 29881: Run Core Tests
Build 29880: arc lint + arc unit

Event Timeline

It's also possible we could benefit from doing this in Differential, which builds a similar query, but I'll wait until we confirm that this was a good idea first.

This revision is now accepted and ready to land.Feb 7 2019, 11:24 PM
This revision was automatically updated to reflect the committed changes.