Page MenuHomePhabricator

When an Owners package accepts a revision, count that as an "involved owner" for the purposes of audit
ClosedPublic

Authored by epriestley on Feb 7 2019, 9:52 PM.

Details

Summary

Depends on D20129. Ref T13244. See PHI1058. When a revision has an "Accept" from a package, count the owners as "involved" in the change whether or not any actual human owners are actually accepting reviewers.

If a user owns "/" and uses "force accept" to cause "/src/javascript" to accept, or a user who legitimately owns "/src/javascript" accepts on behalf of the package but not on behalf of themselves (for whatever reason), it generally makes practical sense that these changes have owners involved in them (i.e., that's what a normal user would expect in both cases) and don't need to trigger audits under "no involvement" rules.

Test Plan

Used bin/repository reparse --force --owners <commit> to trigger audit logic. Saw a commit owned by O1 with a revision counted as "involved" when O1 had accepted the revision, even though no actual human owner had accepted it.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 7 2019, 9:52 PM
epriestley requested review of this revision.Feb 7 2019, 9:54 PM
amckinley accepted this revision.Feb 7 2019, 11:29 PM
This revision is now accepted and ready to land.Feb 7 2019, 11:29 PM
This revision was automatically updated to reflect the committed changes.