Differential D20128

Autofocus form control for adding TOTP codes
ClosedPublic
Actions

Authored by amckinley on Feb 7 2019, 7:37 PM.

Details

Reviewers

Commits

rPf2236eb061a6: Autofocus form control for adding TOTP codes

Summary

Ref D20122. This is something I wanted in a bunch of places. Looks like at some point the most-annoying one (autofocus for entering TOTOP codes) already got fixed at some point.

Test Plan

Loaded the form, got autofocus as expected.

Diff Detail

Repository

rP Phabricator

Branch

autofocus (branched from master)

Lint

Lint Errors

Severity	Location	Code	Message
Error	/Users/amckinley/src/phacility/core/lib/libphutil/src/filesystem/Filesystem.php:428	PHL1	Unknown Symbol
Error	/Users/amckinley/src/phacility/core/lib/libphutil/src/filesystem/Filesystem.php:568	PHL1	Unknown Symbol

Unit

Tests Passed

Build Status

Buildable 21885
Build 29879: Run Core Tests
Build 29878: arc lint + arc unit

Event Timeline

amckinley created this revision.Feb 7 2019, 7:37 PM

Harbormaster completed remote builds in B21885: Diff 48048.Feb 7 2019, 7:39 PM

amckinley requested review of this revision.Feb 7 2019, 7:39 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 7 2019, 7:39 PM

When forms load in an Ajax dialog, I think we autofocus the first input, but don't do that if dialogs load on standalone pages. I don't think this can hurt, at least.

This revision is now accepted and ready to land.Feb 7 2019, 7:48 PM

Closed by commit rPf2236eb061a6: Autofocus form control for adding TOTP codes (authored by amckinley). · Explain WhyFeb 7 2019, 7:56 PM

This revision was automatically updated to reflect the committed changes.