Page MenuHomePhabricator

Remove "iconv" PHP extension dependency
ClosedPublic

Authored by epriestley on Jan 30 2019, 10:51 PM.
Tags
None
Referenced Files
F17836832: D20070.id.diff
Sat, Jul 26, 4:36 PM
F17599327: D20070.diff
Tue, Jul 8, 6:39 PM
Unknown Object (File)
Jun 16 2025, 11:00 AM
Unknown Object (File)
Jun 6 2025, 5:55 PM
Unknown Object (File)
May 7 2025, 6:57 PM
Unknown Object (File)
May 6 2025, 11:58 PM
Unknown Object (File)
Apr 27 2025, 2:59 PM
Unknown Object (File)
Apr 26 2025, 5:22 PM
Subscribers
None

Details

Summary

Depends on D20069. Ref T13232. This is a very, very weak dependency and we can reasonably polyfill it.

Test Plan

Grepped for iconv in libphutil, arcanist, and Phabricator.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 31 2019, 2:47 AM
This revision was automatically updated to reflect the committed changes.