Page MenuHomePhabricator

Remove "iconv" PHP extension dependency
ClosedPublic

Authored by epriestley on Wed, Jan 30, 10:51 PM.

Details

Summary

Depends on D20069. Ref T13232. This is a very, very weak dependency and we can reasonably polyfill it.

Test Plan

Grepped for iconv in libphutil, arcanist, and Phabricator.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Jan 30, 10:51 PM
epriestley requested review of this revision.Wed, Jan 30, 10:53 PM
amckinley accepted this revision.Thu, Jan 31, 2:47 AM
This revision is now accepted and ready to land.Thu, Jan 31, 2:47 AM
This revision was automatically updated to reflect the committed changes.