Differential D20070

Remove "iconv" PHP extension dependency
ClosedPublic
Actions

Authored by epriestley on Jan 30 2019, 10:51 PM.

Tags

None

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13232: Mac OS X Mojave, SIP, Code Signing, and Apache

Commits

rP87b0ef883905: Remove "iconv" PHP extension dependency

Summary

Depends on D20069. Ref T13232. This is a very, very weak dependency and we can reasonably polyfill it.

Test Plan

Grepped for iconv in libphutil, arcanist, and Phabricator.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 30 2019, 10:51 PM

Harbormaster completed remote builds in B21770: Diff 47920.Jan 30 2019, 10:53 PM

epriestley requested review of this revision.Jan 30 2019, 10:53 PM

amckinley accepted this revision.Jan 31 2019, 2:47 AM

This revision is now accepted and ready to land.Jan 31 2019, 2:47 AM

Closed by commit rP87b0ef883905: Remove "iconv" PHP extension dependency (authored by epriestley). · Explain WhyJan 31 2019, 3:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			scripts/mail/mail_handler.php (4 lines)
M			src/applications/config/check/PhabricatorExtensionsSetupCheck.php (3 lines)
M			src/applications/config/controller/PhabricatorConfigVersionController.php (2 lines)

Diff 47931

scripts/mail/mail_handler.php

Loading...

src/applications/config/check/PhabricatorExtensionsSetupCheck.php

Loading...

src/applications/config/controller/PhabricatorConfigVersionController.php

Loading...