Page MenuHomePhabricator
Differential D20070

Remove "iconv" PHP extension dependency
ClosedPublic
Actions

Authored by epriestley on Jan 30 2019, 10:51 PM.
Tags
None
Referenced Files
F15533233: D20070.id47931.diff
Wed, Apr 23, 6:50 PM
F15531174: D20070.diff
Wed, Apr 23, 10:03 AM
F15505972: D20070.id.diff
Tue, Apr 15, 7:27 AM
F15493061: D20070.id.diff
Sat, Apr 12, 9:11 PM
F15471169: D20070.diff
Sat, Apr 5, 3:51 AM
F15463174: D20070.id47920.diff
Tue, Apr 1, 9:04 PM
F15438357: D20070.id47931.diff
Wed, Mar 26, 12:19 AM
F15437050: D20070.id.diff
Tue, Mar 25, 5:10 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13232: Mac OS X Mojave, SIP, Code Signing, and Apache
Commits
rP87b0ef883905: Remove "iconv" PHP extension dependency
Summary

Depends on D20069. Ref T13232. This is a very, very weak dependency and we can reasonably polyfill it.

Test Plan

Grepped for iconv in libphutil, arcanist, and Phabricator.

Diff Detail

Repository
rP Phabricator
Branch
cache2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/config/check/PhabricatorExtensionsSetupCheck.php:14XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 21770
Build 29708: Run Core Tests
Build 29707: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 30 2019, 10:51 PM
Harbormaster completed remote builds in B21770: Diff 47920.Jan 30 2019, 10:53 PM
epriestley requested review of this revision.Jan 30 2019, 10:53 PM
amckinley accepted this revision.Jan 31 2019, 2:47 AM
This revision is now accepted and ready to land.Jan 31 2019, 2:47 AM
Closed by commit rP87b0ef883905: Remove "iconv" PHP extension dependency (authored by epriestley). · Explain WhyJan 31 2019, 3:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
scripts/
mail/
4 lines
src/
applications/
config/
check/
3 lines
controller/
2 lines

Diff 47920

View Options

scripts/mail/mail_handler.php

Loading...
View Options

src/applications/config/check/PhabricatorExtensionsSetupCheck.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigVersionController.php

Loading...
Phabricator · Built by Phacility