Page MenuHomePhabricator
Differential D20045

Add a warning about MFA requirements to edit forms
ClosedPublic
Actions

Authored by epriestley on Jan 28 2019, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 6:01 PM
Unknown Object (File)
Sun, Dec 8, 6:43 AM
Unknown Object (File)
Mon, Nov 25, 7:59 AM
Unknown Object (File)
Nov 20 2024, 7:55 PM
Unknown Object (File)
Oct 25 2024, 3:45 PM
Unknown Object (File)
Oct 24 2024, 11:14 PM
Unknown Object (File)
Oct 1 2024, 8:47 PM
Unknown Object (File)
Sep 24 2024, 2:37 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13242: 2019 Week 5 Bonus Content
Commits
rP2374c92544e0: Add a warning about MFA requirements to edit forms
Summary

Depends on D20044. Ref T13242. Similar to D20044, add reminder text to edit forms.

It would be nice to "workflow" these so the MFA flow happens inline, but Maniphest's inline edit behavior currently conflicts with this. Set it aside for now since the next workboards iteration (triggers) is probably a good opportunity to revisit it.

Test Plan

Screen Shot 2019-01-28 at 10.27.40 AM.png (329×699 px, 26 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 28 2019, 6:29 PM
Harbormaster completed remote builds in B21724: Diff 47870.Jan 28 2019, 6:31 PM
epriestley requested review of this revision.Jan 28 2019, 6:31 PM
amckinley added a comment.Jan 29 2019, 2:37 AM

This change looks good, but what exactly does it accomplish? I feel like this would be useful if a user was trying to take an action that required MFA, but their account had no MFA factors configured, but is such a thing even possible? Otherwise this feels like a message that we train users to ignore whenever they see it.

amckinley added a comment.Jan 29 2019, 2:37 AM

Oh, there's more context in D20044, hang on.

amckinley accepted this revision.Jan 29 2019, 2:38 AM

Ok I'm on board.

This revision is now accepted and ready to land.Jan 29 2019, 2:38 AM
epriestley added a comment.Jan 29 2019, 2:39 AM

Yeah, D20044 is the better version of this.

This is just a hint like "go dig your phone out of your bag before writing your entire memoir into this box". The warnings in D20044 are more substantive/useful.

Closed by commit rP2374c92544e0: Add a warning about MFA requirements to edit forms (authored by epriestley). · Explain WhyJan 30 2019, 2:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editengine/
27 lines

Diff 47907

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
Phabricator · Built by Phacility