Page MenuHomePhabricator

Add a warning about MFA requirements to edit forms

Authored by epriestley on Jan 28 2019, 6:29 PM.



Depends on D20044. Ref T13242. Similar to D20044, add reminder text to edit forms.

It would be nice to "workflow" these so the MFA flow happens inline, but Maniphest's inline edit behavior currently conflicts with this. Set it aside for now since the next workboards iteration (triggers) is probably a good opportunity to revisit it.

Test Plan

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 28 2019, 6:29 PM
epriestley requested review of this revision.Jan 28 2019, 6:31 PM

This change looks good, but what exactly does it accomplish? I feel like this would be useful if a user was trying to take an action that required MFA, but their account had no MFA factors configured, but is such a thing even possible? Otherwise this feels like a message that we train users to ignore whenever they see it.

Oh, there's more context in D20044, hang on.

amckinley accepted this revision.Jan 29 2019, 2:38 AM

Ok I'm on board.

This revision is now accepted and ready to land.Jan 29 2019, 2:38 AM

Yeah, D20044 is the better version of this.

This is just a hint like "go dig your phone out of your bag before writing your entire memoir into this box". The warnings in D20044 are more substantive/useful.

This revision was automatically updated to reflect the committed changes.