Page MenuHomePhabricator

Warn users about MFA requirements when interacting with "MFA Required" objects via the comment form
ClosedPublic

Authored by epriestley on Mon, Jan 28, 6:06 PM.

Details

Summary

Ref T13242. Warn user that they'll need to MFA (so they can go dig their phone out of their bag first or whatever, or don't type a giant comment on mobile if their U2F key is back at the office) on the comment form.

Also, when they'll need MFA and won't be able to provide it (no MFA on account), stop them from typing up a big comment that they can't actually submit: point them at MFA setup first.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, Jan 28, 6:06 PM
epriestley requested review of this revision.Mon, Jan 28, 6:08 PM
epriestley updated this revision to Diff 47869.Mon, Jan 28, 6:10 PM
  • Slightly less technical langauge ("submit this form" -> "comment or make changes").
amckinley accepted this revision.Tue, Jan 29, 2:39 AM
amckinley added inline comments.
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
221

"but you do not"

This revision is now accepted and ready to land.Tue, Jan 29, 2:39 AM
epriestley updated this revision to Diff 47882.Tue, Jan 29, 2:49 AM
  • Wordsmithing.
This revision was automatically updated to reflect the committed changes.