Page MenuHomePhabricator

Warn users about MFA requirements when interacting with "MFA Required" objects via the comment form
ClosedPublic

Authored by epriestley on Jan 28 2019, 6:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 5:29 AM
Unknown Object (File)
Fri, Nov 29, 8:23 PM
Unknown Object (File)
Tue, Nov 26, 3:48 AM
Unknown Object (File)
Mon, Nov 25, 7:59 AM
Unknown Object (File)
Fri, Nov 22, 8:04 AM
Unknown Object (File)
Sun, Nov 17, 4:04 PM
Unknown Object (File)
Thu, Nov 14, 2:15 PM
Unknown Object (File)
Sun, Nov 10, 2:29 AM
Subscribers
None

Details

Summary

Ref T13242. Warn user that they'll need to MFA (so they can go dig their phone out of their bag first or whatever, or don't type a giant comment on mobile if their U2F key is back at the office) on the comment form.

Also, when they'll need MFA and won't be able to provide it (no MFA on account), stop them from typing up a big comment that they can't actually submit: point them at MFA setup first.

Test Plan

Screen Shot 2019-01-28 at 9.58.52 AM.png (396×1 px, 28 KB)

Screen Shot 2019-01-28 at 10.01.03 AM.png (186×1 px, 18 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Slightly less technical langauge ("submit this form" -> "comment or make changes").
amckinley added inline comments.
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
221

"but you do not"

This revision is now accepted and ready to land.Jan 29 2019, 2:39 AM
This revision was automatically updated to reflect the committed changes.