Page MenuHomePhabricator
Differential D20030

Update Google OAuth adapter to move away from deprecated "Google+" APIs
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 1:48 AM.
Tags
None
Referenced Files
F13046832: D20030.id47836.diff
Thu, Apr 18, 12:30 PM
Unknown Object (File)
Mar 19 2024, 3:46 AM
Unknown Object (File)
Mar 4 2024, 10:50 PM
Unknown Object (File)
Feb 3 2024, 8:59 PM
Unknown Object (File)
Jan 25 2024, 1:45 AM
Unknown Object (File)
Jan 9 2024, 4:38 PM
Unknown Object (File)
Dec 27 2023, 1:03 PM
Unknown Object (File)
Dec 27 2023, 1:03 PM
View All 82 Files
Subscribers
dragoon20
reed

Details

Reviewers
amckinley
dragoon20
Maniphest Tasks
T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019
Commits
rPHU9144fc5a6896: (stable) Promote 2019 Week 4
rPHU9456d6683d33: Update Google OAuth adapter to move away from deprecated "Google+" APIs
Summary

Fixes T13227.

Test Plan

Screen Shot 2019-01-24 at 5.47.10 PM.png (807×1 px, 168 KB)

Diff Detail

Repository
rPHU libphutil
Branch
google1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21690
Build 29581: Run Core Tests
Build 29580: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 25 2019, 1:48 AM
Harbormaster completed remote builds in B21690: Diff 47836.Jan 25 2019, 1:49 AM
epriestley requested review of this revision.Jan 25 2019, 1:49 AM
epriestley added inline comments.Jan 25 2019, 1:50 AM
src/auth/PhutilGoogleAuthAdapter.php
150

None of these instructions seem to make sense anymore and I suspect this "Enable Google+" error is now impossible. Fingers crossed until evidence surfaces to suggest otherwise.

epriestley mentioned this in D20015: Adjust Google Auth Adapter to use Open ID Connect.Jan 25 2019, 1:51 AM
dragoon20 accepted this revision.Jan 25 2019, 3:04 AM
dragoon20 added a subscriber: dragoon20.

I tested this and it works marvelous, thanks, waiting for the patch.

Macro lgtmacro:

This revision is now accepted and ready to land.Jan 25 2019, 3:04 AM
Closed by commit rPHU9456d6683d33: Update Google OAuth adapter to move away from deprecated "Google+" APIs (authored by epriestley). · Explain WhyJan 28 2019, 5:40 PM
This revision was automatically updated to reflect the committed changes.
reed added a subscriber: reed.Feb 22 2019, 4:40 PM

Revision Contents
Changeset List

PathSize
src/
auth/
92 lines

Diff 47836

View Options

src/auth/PhutilGoogleAuthAdapter.php

Loading...
Phabricator · Built by Phacility