Page MenuHomePhabricator

Fix an issue where "Import Columns" could fail on a board for a project with milestones
ClosedPublic

Authored by epriestley on Jan 16 2019, 2:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 1:36 AM
Unknown Object (File)
Mon, Dec 16, 5:52 PM
Unknown Object (File)
Tue, Dec 10, 8:24 PM
Unknown Object (File)
Fri, Dec 6, 6:44 AM
Unknown Object (File)
Fri, Nov 29, 10:46 AM
Unknown Object (File)
Wed, Nov 27, 11:11 AM
Unknown Object (File)
Nov 21 2024, 8:03 PM
Unknown Object (File)
Nov 19 2024, 11:06 AM
Subscribers
None

Details

Summary

See PHI1025. When you "Import Columns", we test if you're trying to import into a board that already has columns. However, this test is too broad (it incorrectly detects "proxy" columns for milestones as columns) and not user-friendly (it returns 400 instead of a readable error).

Correct these issues, and refine some of the logic around proxy columns.

Test Plan
  • Created a project, A.
  • Created a milestone under that project.
  • Imported another project's columns to A's workboard.
    • Before change: Unhelpful 400.
    • After change: import worked fine.
  • Also, hit the new error dialogs and read through them.

Diff Detail

Repository
rP Phabricator
Branch
board1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21533
Build 29347: Run Core Tests
Build 29346: arc lint + arc unit

Event Timeline

amckinley added inline comments.
src/applications/project/controller/PhabricatorProjectBoardImportController.php
57

"Source Workboard Has No Columns", if I understand this right.

This revision is now accepted and ready to land.Jan 17 2019, 12:03 AM
src/applications/project/controller/PhabricatorProjectBoardImportController.php
57

Ah, yeah, I think your phrasing is more clear. You just "targeted" this workboard by typing in the name, but it's not really self-evident whether "target" means "source" or "destination".

  • Use "Source" over "Target".
This revision was automatically updated to reflect the committed changes.