Page MenuHomePhabricator
Differential D19972

Reorder "Merge" transaction to make "Close as Duplicate" produce a "[Merged]" email subject
ClosedPublic
Actions

Authored by epriestley on Jan 14 2019, 10:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 9:01 AM
Unknown Object (File)
Thu, Dec 12, 2:08 AM
Unknown Object (File)
Wed, Dec 11, 12:40 PM
Unknown Object (File)
Tue, Dec 10, 11:53 PM
Unknown Object (File)
Mon, Dec 9, 2:47 PM
Unknown Object (File)
Sat, Dec 7, 5:14 PM
Unknown Object (File)
Sat, Dec 7, 7:39 AM
Unknown Object (File)
Fri, Dec 6, 11:23 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T11782: Inconsistent mail notification subject ([Updated] vs [Merged]) depending on from which task a duplicate task was merged
Commits
rPdc4d7f1f3e8d: Reorder "Merge" transaction to make "Close as Duplicate" produce a "[Merged]"…
Summary

Fixes T11782. When you "Close as Duplicate", generate a "[Merged]" email by making the merge the first transaction.

(There are other, more-deterministic ways to do this with action strength, but this is much simpler and I believe it suffices.)

Test Plan

Used "Close as Duplicate", got a "[Merged]" email out of it.

Diff Detail

Repository
rP Phabricator
Branch
mfa16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21524
Build 29330: Run Core Tests
Build 29329: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
relationship/
9 lines

Diff 47671

View Options

src/applications/maniphest/relationship/ManiphestTaskRelationship.php

Loading...
Phabricator · Built by Phacility