Page MenuHomePhabricator

Raise warning when accidentally submitting Conduit parameters as a JSON-encoded body
ClosedPublic

Authored by amckinley on Jan 3 2019, 1:26 AM.
Tags
None
Referenced Files
F12816416: D19944.id47609.diff
Thu, Mar 28, 3:40 AM
Unknown Object (File)
Fri, Mar 22, 9:55 PM
Unknown Object (File)
Feb 12 2024, 9:18 PM
Unknown Object (File)
Feb 3 2024, 8:37 PM
Unknown Object (File)
Jan 6 2024, 4:33 PM
Unknown Object (File)
Dec 22 2023, 1:07 AM
Unknown Object (File)
Dec 22 2023, 1:07 AM
Unknown Object (File)
Dec 22 2023, 1:07 AM
Subscribers

Details

Summary

See T12447 for discussion. It is reasonably intuitive to try and pass Conduit parameters via a JSON-encoded HTTP body, but if you do so, you'll get an unhelpful messsage about how method so-and-so does not accept a parameter named "your_entire_json_body". Instead, detect this mistake and advise developers to use form-encoded parameters.

Test Plan

Got a better error when attempting to make Conduit calls from React code. Tested the following additional invocations of Conduit and got the expected results without an error:

  • From the Conduit UI
  • With cURL:
~ $ curl http://local.phacility.com:8080/api/conpherence.querythread \
>     -d api.token=api-tvv2zb565zrtueab5ddprmpxvrwb \
>     -d ids[0]=1
  • With arc call-conduit:
~ $ echo '{
>   "ids": [
>     1
>   ]
> }' | arc call-conduit --conduit-uri http://local.phacility.com:8080/ --conduit-token api-tvv2zb565zrtueab5ddprmpxvrwb conpherence.querythread

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable