Page MenuHomePhabricator

Raise warning when accidentally submitting Conduit parameters as a JSON-encoded body
ClosedPublic

Authored by amckinley on Jan 3 2019, 1:26 AM.
Tags
None
Referenced Files
F14757525: D19944.id47609.diff
Wed, Jan 22, 1:48 AM
F14751639: D19944.id.diff
Tue, Jan 21, 12:38 PM
Unknown Object (File)
Thu, Jan 2, 9:01 PM
Unknown Object (File)
Fri, Dec 27, 3:04 PM
Unknown Object (File)
Thu, Dec 26, 10:21 AM
Unknown Object (File)
Dec 20 2024, 7:11 PM
Unknown Object (File)
Dec 19 2024, 10:57 PM
Unknown Object (File)
Dec 10 2024, 12:26 PM
Subscribers

Details

Summary

See T12447 for discussion. It is reasonably intuitive to try and pass Conduit parameters via a JSON-encoded HTTP body, but if you do so, you'll get an unhelpful messsage about how method so-and-so does not accept a parameter named "your_entire_json_body". Instead, detect this mistake and advise developers to use form-encoded parameters.

Test Plan

Got a better error when attempting to make Conduit calls from React code. Tested the following additional invocations of Conduit and got the expected results without an error:

  • From the Conduit UI
  • With cURL:
~ $ curl http://local.phacility.com:8080/api/conpherence.querythread \
>     -d api.token=api-tvv2zb565zrtueab5ddprmpxvrwb \
>     -d ids[0]=1
  • With arc call-conduit:
~ $ echo '{
>   "ids": [
>     1
>   ]
> }' | arc call-conduit --conduit-uri http://local.phacility.com:8080/ --conduit-token api-tvv2zb565zrtueab5ddprmpxvrwb conpherence.querythread

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable