Page MenuHomePhabricator

Raise warning when accidentally submitting Conduit parameters as a JSON-encoded body
ClosedPublic

Authored by amckinley on Jan 3 2019, 1:26 AM.
Tags
None
Referenced Files
F15470365: D19944.id47610.diff
Apr 4 2025, 9:41 PM
F15466276: D19944.id47609.diff
Apr 3 2025, 3:47 AM
F15465040: D19944.id47610.diff
Apr 2 2025, 1:57 PM
F15463792: D19944.diff
Apr 2 2025, 3:19 AM
F15463294: D19944.id.diff
Apr 1 2025, 10:08 PM
F15459334: D19944.diff
Mar 31 2025, 12:00 PM
F15415976: D19944.diff
Mar 20 2025, 8:36 AM
F15395215: D19944.diff
Mar 16 2025, 3:49 AM
Subscribers

Details

Summary

See T12447 for discussion. It is reasonably intuitive to try and pass Conduit parameters via a JSON-encoded HTTP body, but if you do so, you'll get an unhelpful messsage about how method so-and-so does not accept a parameter named "your_entire_json_body". Instead, detect this mistake and advise developers to use form-encoded parameters.

Test Plan

Got a better error when attempting to make Conduit calls from React code. Tested the following additional invocations of Conduit and got the expected results without an error:

  • From the Conduit UI
  • With cURL:
~ $ curl http://local.phacility.com:8080/api/conpherence.querythread \
>     -d api.token=api-tvv2zb565zrtueab5ddprmpxvrwb \
>     -d ids[0]=1
  • With arc call-conduit:
~ $ echo '{
>   "ids": [
>     1
>   ]
> }' | arc call-conduit --conduit-uri http://local.phacility.com:8080/ --conduit-token api-tvv2zb565zrtueab5ddprmpxvrwb conpherence.querythread

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable