Page MenuHomePhabricator

Remove standalone SMS support in favor of a "Mail, SMS, and other media are mostly the same thing" approach
ClosedPublic

Authored by epriestley on Jan 2 2019, 4:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 6:50 AM
Unknown Object (File)
Sun, Oct 27, 9:14 AM
Unknown Object (File)
Sep 26 2024, 7:37 PM
Unknown Object (File)
Sep 23 2024, 7:12 AM
Unknown Object (File)
Sep 9 2024, 10:55 PM
Unknown Object (File)
Sep 6 2024, 4:53 AM
Unknown Object (File)
Sep 6 2024, 4:53 AM
Unknown Object (File)
Sep 6 2024, 4:53 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T920. Over time, mail has become much more complex and I think considering "mail", "sms", "postcards", "whatsapp", etc., to be mostly-the-same is now a more promising avenue than building separate stacks for each one.

Throw away all the standalone SMS code, including the Twilio config options. I have a separate diff that adds Twilio as a mail adapter and functions correctly, but it needs some more work to bring upstream.

This permanently destroys the sms table, which no real reachable code ever wrote to. I'll call this out in the changelog.

Test Plan
  • Grepped for SMS and Twilio.
  • Ran storage upgrade.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable