Page MenuHomePhabricator

Remove standalone SMS support in favor of a "Mail, SMS, and other media are mostly the same thing" approach
ClosedPublic

Authored by epriestley on Jan 2 2019, 4:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 10, 9:03 AM
Unknown Object (File)
Thu, Mar 21, 11:04 PM
Unknown Object (File)
Mar 10 2024, 2:11 AM
Unknown Object (File)
Feb 24 2024, 7:16 PM
Unknown Object (File)
Feb 22 2024, 7:05 AM
Unknown Object (File)
Jan 13 2024, 8:34 PM
Unknown Object (File)
Jan 4 2024, 8:47 AM
Unknown Object (File)
Dec 29 2023, 4:01 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T920. Over time, mail has become much more complex and I think considering "mail", "sms", "postcards", "whatsapp", etc., to be mostly-the-same is now a more promising avenue than building separate stacks for each one.

Throw away all the standalone SMS code, including the Twilio config options. I have a separate diff that adds Twilio as a mail adapter and functions correctly, but it needs some more work to bring upstream.

This permanently destroys the sms table, which no real reachable code ever wrote to. I'll call this out in the changelog.

Test Plan
  • Grepped for SMS and Twilio.
  • Ran storage upgrade.

Diff Detail

Repository
rP Phabricator
Branch
mfa5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21455
Build 29217: Run Core Tests
Build 29216: arc lint + arc unit