Page MenuHomePhabricator

Remove standalone SMS support in favor of a "Mail, SMS, and other media are mostly the same thing" approach
ClosedPublic

Authored by epriestley on Jan 2 2019, 4:03 AM.

Details

Summary

Ref T920. Over time, mail has become much more complex and I think considering "mail", "sms", "postcards", "whatsapp", etc., to be mostly-the-same is now a more promising avenue than building separate stacks for each one.

Throw away all the standalone SMS code, including the Twilio config options. I have a separate diff that adds Twilio as a mail adapter and functions correctly, but it needs some more work to bring upstream.

This permanently destroys the sms table, which no real reachable code ever wrote to. I'll call this out in the changelog.

Test Plan
  • Grepped for SMS and Twilio.
  • Ran storage upgrade.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 2 2019, 4:03 AM
Owners added a subscriber: Restricted Owners Package.Jan 2 2019, 4:03 AM
epriestley requested review of this revision.Jan 2 2019, 4:05 AM
amckinley accepted this revision.Jan 3 2019, 12:32 AM
This revision is now accepted and ready to land.Jan 3 2019, 12:32 AM
This revision was automatically updated to reflect the committed changes.