Page MenuHomePhabricator

Remove standalone SMS support in favor of a "Mail, SMS, and other media are mostly the same thing" approach
ClosedPublic

Authored by epriestley on Jan 2 2019, 4:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jul 2 2022, 5:49 AM
Unknown Object (File)
Jun 29 2022, 1:10 PM
Unknown Object (File)
Jun 19 2022, 4:50 PM
Unknown Object (File)
Jun 14 2022, 2:54 PM
Unknown Object (File)
Jun 14 2022, 1:59 AM
Unknown Object (File)
Jun 12 2022, 8:43 AM
Unknown Object (File)
Jun 6 2022, 11:00 PM
Unknown Object (File)
May 29 2022, 2:07 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T920. Over time, mail has become much more complex and I think considering "mail", "sms", "postcards", "whatsapp", etc., to be mostly-the-same is now a more promising avenue than building separate stacks for each one.

Throw away all the standalone SMS code, including the Twilio config options. I have a separate diff that adds Twilio as a mail adapter and functions correctly, but it needs some more work to bring upstream.

This permanently destroys the sms table, which no real reachable code ever wrote to. I'll call this out in the changelog.

Test Plan
  • Grepped for SMS and Twilio.
  • Ran storage upgrade.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable