Page MenuHomePhabricator

Give sessions real PHIDs and slightly modernize session queries
ClosedPublic

Authored by epriestley on Dec 13 2018, 6:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 11:52 AM
Unknown Object (File)
Thu, Mar 21, 11:52 AM
Unknown Object (File)
Thu, Mar 21, 11:52 AM
Unknown Object (File)
Tue, Mar 5, 10:55 AM
Unknown Object (File)
Feb 9 2024, 12:52 PM
Unknown Object (File)
Feb 3 2024, 8:14 PM
Unknown Object (File)
Jan 7 2024, 4:48 PM
Unknown Object (File)
Jan 3 2024, 7:11 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13222. See PHI873. I'm preparing to introduce a new MFA "Challenge" table which stores state about challenges we've issued (to bind challenges to sessions and prevent most challenge reuse).

This table will reference sessions (since each challenge will be bound to a particular session) but sessions currently don't have PHIDs. Give them PHIDs and slightly modernize some related code.

Test Plan
  • Ran migrations.
  • Verified table got PHIDs.
  • Used var_dump() to dump an organic user session.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Dec 13 2018, 6:34 PM
This revision is now accepted and ready to land.Dec 13 2018, 7:48 PM
This revision was automatically updated to reflect the committed changes.