Differential D19880

Fix another qsprintf() straggler in "Has Open Subtasks"
ClosedPublic
Actions

Authored by epriestley on Dec 13 2018, 12:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 24, 11:02 PM

	Unknown Object (File)
	Wed, Nov 20, 8:19 PM

	Unknown Object (File)
	Wed, Nov 20, 7:11 PM

	Unknown Object (File)
	Sun, Nov 17, 4:30 AM

	Unknown Object (File)
	Mon, Nov 4, 10:40 AM

	Unknown Object (File)
	Mon, Nov 4, 10:40 AM

	Unknown Object (File)
	Mon, Nov 4, 10:40 AM

	Unknown Object (File)
	Sun, Nov 3, 1:54 AM

View All Files

Subscribers

joshuaspence

Details

Reviewers

amckinley
joshuaspence

Commits

rPecae936d9701: Fix another qsprintf() straggler in "Has Open Subtasks"

Summary

See https://discourse.phabricator-community.org/t/error-message-is-not-being-logged-when-unable-to-connect-to-the-database/2201/.

Test Plan

Queried for "With Open Subtasks" and "With No Open Subtasks".

Diff Detail

Repository

rP Phabricator

Branch

query9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21326
Build 29019: Run Core Tests
Build 29018: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 13 2018, 12:56 AM

Harbormaster completed remote builds in B21326: Diff 47475.Dec 13 2018, 12:58 AM

epriestley requested review of this revision.Dec 13 2018, 12:58 AM

Looks about right.

This revision is now accepted and ready to land.Dec 13 2018, 1:07 AM

Closed by commit rPecae936d9701: Fix another qsprintf() straggler in "Has Open Subtasks" (authored by epriestley). · Explain WhyDec 13 2018, 1:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

query/

ManiphestTaskQuery.php

4 lines

Diff 47475

View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Fix another qsprintf() straggler in "Has Open Subtasks"ClosedPublicActions