Differential D19868

Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule
ClosedPublic
Actions

Authored by epriestley on Dec 12 2018, 1:16 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rARCed5d02ab3ef9: (stable) Promote 2018 Week 50
rARCeb732555a71a: Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule

Summary

See https://discourse.phabricator-community.org/t/arc-diff-fails-on-incompatible-linter-rule-with-php7-3/2198.

Test Plan

Looked at the code carefully.

Diff Detail

Repository

Branch

continue1

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 21299
Build 28977: Run Core Tests
Build 28976: arc lint + arc unit

Unit TestsFailed
View All

Excuse: JSHint version discrepcancy

	Time	Test
	886 ms	ArcanistJSHintLinterTestCase::Unknown Unit Message ("") In 'jshint.lint-test', expected lint to raise error on line 9 at char 0, but no error was raised. Actually raised: warning at line 3, char 8: W033 JSHintW033 error at line 7, char 1: E019 JSHintE019
	41 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("") 7 assertions passed.
	29 ms	ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("") 7 assertions passed.
	21 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("") 3 assertions passed.
	12 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("") 3 assertions passed.
		View Full Test Results (1 Failed · 292 Passed · 66 Skipped)

Event Timeline

epriestley created this revision.Dec 12 2018, 1:16 PM

Harbormaster completed remote builds in B21299: Diff 47446.Dec 12 2018, 1:17 PM

epriestley requested review of this revision.Dec 12 2018, 1:17 PM

Test failure is a JSHint version thing and will be mooted by T13098, which either removes or rewrites it.

amckinley accepted this revision.Dec 12 2018, 4:32 PM

This revision is now accepted and ready to land.Dec 12 2018, 4:32 PM

Closed by commit rARCeb732555a71a: Fix a "continue;" inside a switch in ArcanistPHPCompatibilityXHPASTLinterRule (authored by epriestley). · Explain WhyDec 12 2018, 5:22 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D19749: Address continue statement scope.May 14 2019, 2:15 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistPHPCompatibilityXHPASTLinterRule.php

2 lines

Diff 47446

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

Loading...