Fix handling of Phriction conduit edits
ClosedPublic
Actions

Authored by amckinley on Dec 10 2018, 8:53 PM.

Details

Reviewers

epriestley

Commits

rP00a7071e2d1d: Fix handling of Phriction conduit edits

Summary

See https://discourse.phabricator-community.org/t/conduit-method-phriction-edit-requires-title-while-the-docs-say-its-optional/2176. Make code consistent with documentation by not requiring either content or title.

Test Plan

Hit the method via the UI and no longer got an error on missing content or title fields.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21278
Build 28948: Run Core Tests
Build 28947: arc lint + arc unit

Event Timeline

amckinley created this revision.Dec 10 2018, 8:53 PM

Harbormaster completed remote builds in B21278: Diff 47425.Dec 10 2018, 8:54 PM

amckinley requested review of this revision.Dec 10 2018, 8:54 PM

Herald added a subscriber: Korvin. · View Herald TranscriptDec 10 2018, 8:54 PM

These should probably be strlen(...) tests -- as written, setting the title or content to 0 likely does not work.

This revision is now accepted and ready to land.Dec 10 2018, 9:00 PM

Switch to strlen.

Closed by commit rP00a7071e2d1d: Fix handling of Phriction conduit edits (authored by amckinley). · Explain WhyDec 10 2018, 9:38 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B21279: Diff 47426.Dec 10 2018, 9:39 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

conduit/

PhrictionEditConduitAPIMethod.php

19 lines

Diff 47425

View Options

src/applications/phriction/conduit/PhrictionEditConduitAPIMethod.php

Fix handling of Phriction conduit editsClosedPublicActions