Page MenuHomePhabricator

Fix handling of Phriction conduit edits
ClosedPublic

Authored by amckinley on Dec 10 2018, 8:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 10:39 PM
Unknown Object (File)
Tue, Mar 19, 10:58 PM
Unknown Object (File)
Tue, Mar 19, 10:58 PM
Unknown Object (File)
Tue, Mar 19, 10:58 PM
Unknown Object (File)
Tue, Mar 19, 10:58 PM
Unknown Object (File)
Tue, Mar 19, 10:58 PM
Unknown Object (File)
Feb 15 2024, 1:43 AM
Unknown Object (File)
Feb 10 2024, 1:22 AM
Subscribers

Details

Summary

See https://discourse.phabricator-community.org/t/conduit-method-phriction-edit-requires-title-while-the-docs-say-its-optional/2176. Make code consistent with documentation by not requiring either content or title.

Test Plan

Hit the method via the UI and no longer got an error on missing content or title fields.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

These should probably be strlen(...) tests -- as written, setting the title or content to 0 likely does not work.

This revision is now accepted and ready to land.Dec 10 2018, 9:00 PM
This revision was automatically updated to reflect the committed changes.