Page MenuHomePhabricator

Share more inline "Done" code between Differential and Diffusion
ClosedPublic

Authored by epriestley on Dec 10 2018, 6:40 PM.
Tags
None
Referenced Files
F15308958: D19858.id47437.diff
Thu, Mar 6, 6:47 AM
F15308957: D19858.id47421.diff
Thu, Mar 6, 6:47 AM
F15308956: D19858.id.diff
Thu, Mar 6, 6:47 AM
F15308953: D19858.diff
Thu, Mar 6, 6:46 AM
Unknown Object (File)
Sun, Mar 2, 6:40 PM
Unknown Object (File)
Sun, Feb 23, 1:58 PM
Unknown Object (File)
Feb 14 2025, 12:17 AM
Unknown Object (File)
Feb 9 2025, 6:44 AM
Subscribers
None

Details

Summary

Ref T13222. See PHI995. Before making a change to inline rendering, consolidate this code for generating the "alice added inlines comments." and "alice marked X inlines as done." transactions.

Both Differential and Diffusion have four very similar chunks of code. Merge them into shared methods and reduce code duplication across the methods.

(In the next change, I plan to hide the "done" story when the mark affects your own inline, since users marking their own inlines as "done" is generally not very interesting or useful.)

Test Plan

As author and reviewer/auditor, added inlines in Differential and Diffusion. As author, marked own and others inlines as done and undone. Got sensible transaction rendering and persistence of "Done".

Diff Detail

Repository
rP Phabricator
Branch
inline1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21274
Build 28940: Run Core Tests
Build 28939: arc lint + arc unit