Differential D19857

Give "Track Only" repository detail proper getters/setters
ClosedPublic
Actions

Authored by epriestley on Dec 10 2018, 4:06 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13222: 2018 Week 48-51 Bonus Content

Commits

rPbf6c534b567a: Give "Track Only" repository detail proper getters/setters

Summary

Depends on D19856. Ref T13222. See D19829. Make access to "Track Only" slightly cleaner and more consistent..

Test Plan

Set, edited, and removed "Track Only" settings for a repository. Saw sensible persistence and display behaviors.

Diff Detail

Repository

rP Phabricator

Branch

details2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21271
Build 28936: Run Core Tests
Build 28935: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 10 2018, 4:06 PM

Harbormaster completed remote builds in B21271: Diff 47418.Dec 10 2018, 4:08 PM

epriestley requested review of this revision.Dec 10 2018, 4:08 PM

epriestley mentioned this in T13222: 2018 Week 48-51 Bonus Content.Dec 10 2018, 4:09 PM

amckinley accepted this revision.Dec 10 2018, 6:17 PM

This revision is now accepted and ready to land.Dec 10 2018, 6:17 PM

Closed by commit rPbf6c534b567a: Give "Track Only" repository detail proper getters/setters (authored by epriestley). · Explain WhyDec 10 2018, 6:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

editor/

DiffusionRepositoryEditEngine.php

4 lines

management/

DiffusionRepositoryBranchesManagementPanel.php

8 lines

DiffusionRepositorySubversionManagementPanel.php

2 lines

repository/

storage/

PhabricatorRepository.php

23 lines

__tests__/

PhabricatorRepositoryTestCase.php

6 lines

xaction/

PhabricatorRepositoryTrackOnlyTransaction.php

4 lines

Diff 47418

View Options

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

View Options

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

View Options

src/applications/diffusion/management/DiffusionRepositorySubversionManagementPanel.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/repository/storage/tests/PhabricatorRepositoryTestCase.php

View Options

src/applications/repository/xaction/PhabricatorRepositoryTrackOnlyTransaction.php

Give "Track Only" repository detail proper getters/settersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47418

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php

src/applications/diffusion/management/DiffusionRepositorySubversionManagementPanel.php

src/applications/repository/storage/PhabricatorRepository.php

src/applications/repository/storage/__tests__/PhabricatorRepositoryTestCase.php

src/applications/repository/xaction/PhabricatorRepositoryTrackOnlyTransaction.php

Give "Track Only" repository detail proper getters/setters
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/repository/storage/tests/PhabricatorRepositoryTestCase.php