Page MenuHomePhabricator

Keep the new "%P" query conversion out of the service call profiler by unmasking later
ClosedPublic

Authored by epriestley on Thu, Nov 15, 1:28 PM.

Details

Summary

Ref T13216. Ref T13217. Ref T6960. Although the new "%P" (password/secret) conversion can mask values, we currently convert it too early in the stack, and pass the unmasked query to the service call profiler. This means the unmasked query appears in the service call profiler, etc.

Instead, unmask slightly later in the stack so the call profiler gets the masked string.

Test Plan

See next change.

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Nov 15, 1:28 PM
epriestley requested review of this revision.Thu, Nov 15, 1:29 PM
amckinley accepted this revision.Fri, Nov 16, 7:22 PM
This revision is now accepted and ready to land.Fri, Nov 16, 7:22 PM
This revision was automatically updated to reflect the committed changes.