Paths

Table of Contentst

Differential D19796

Add a convenience function for computing elapsed microtime deltas
ClosedPublic
Actions

Authored by epriestley on Nov 8 2018, 2:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 5:05 PM

	Unknown Object (File)
	Fri, Dec 20, 2:58 PM

	Unknown Object (File)
	Mon, Dec 16, 5:43 AM

	Unknown Object (File)
	Mon, Dec 16, 5:42 AM

	Unknown Object (File)
	Mon, Dec 16, 5:42 AM

	Unknown Object (File)
	Wed, Dec 11, 5:43 PM

	Unknown Object (File)
	Sun, Dec 8, 11:56 AM

	Unknown Object (File)
	Thu, Dec 5, 11:23 AM

Subscribers

None

Details

Reviewers

Commits

rPHUb29d76e1709e: (stable) Promote 2018 Week 45
rPHU335a9f8c2dce: Add a convenience function for computing elapsed microtime deltas

Summary

See D19780. We have a reasonable amount of 1000000 * ($t_end - $t_start) stuff in the codebase that we could simplify. In particular, it would be easy to have too many or too few 0s somewhere and escape notice.

I landed on this method signature instead of phutil_microseconds_between(x, y) since I think it would be hard to remember if parameter order is start, end (chronological) or end, start (like arithmetic subtraction). It should be a little simpler to use in most cases, too.

Test Plan

$ cat test.php
<?php

require_once 'scripts/init/init-script.php';

$start = microtime(true);

sleep(1);

echo phutil_microseconds_since($start);
echo "\n";

$ php -f test.php
1001921

Diff Detail

Repository

Branch

micros1

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/utils/utils.php:1317	XHP45	PHP Compatibility
Error	src/utils/utils.php:1317	XHP45	PHP Compatibility

Unit

Tests Passed

Build Status

Buildable 21118
Build 28709: Run Core Tests
Build 28708: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 8 2018, 2:13 PM

Harbormaster completed remote builds in B21118: Diff 47270.Nov 8 2018, 2:14 PM

epriestley requested review of this revision.Nov 8 2018, 2:14 PM

epriestley added a child revision: D19797: Use phutil_microseconds_since(...) to simplify some timing arithmetic.Nov 8 2018, 3:33 PM

epriestley mentioned this in D19797: Use phutil_microseconds_since(...) to simplify some timing arithmetic.Nov 8 2018, 4:55 PM

amckinley accepted this revision.Nov 8 2018, 7:53 PM

This revision is now accepted and ready to land.Nov 8 2018, 7:53 PM

Closed by commit rPHU335a9f8c2dce: Add a convenience function for computing elapsed microtime deltas (authored by epriestley). · Explain WhyNov 8 2018, 8:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

utils/

23 lines

Diff 47270

src/__phutil_library_map__.php

Loading...

src/utils/utils.php

Loading...