Page MenuHomePhabricator

Add a convenience function for computing elapsed microtime deltas
ClosedPublic

Authored by epriestley on Nov 8 2018, 2:13 PM.
Tags
None
Referenced Files
F12829768: D19796.diff
Thu, Mar 28, 11:42 AM
Unknown Object (File)
Tue, Mar 19, 10:30 PM
Unknown Object (File)
Tue, Mar 19, 10:30 PM
Unknown Object (File)
Tue, Mar 19, 10:30 PM
Unknown Object (File)
Jan 29 2024, 6:45 AM
Unknown Object (File)
Dec 27 2023, 12:55 PM
Unknown Object (File)
Dec 27 2023, 12:55 PM
Unknown Object (File)
Dec 27 2023, 12:55 PM
Subscribers
None

Details

Summary

See D19780. We have a reasonable amount of 1000000 * ($t_end - $t_start) stuff in the codebase that we could simplify. In particular, it would be easy to have too many or too few 0s somewhere and escape notice.

I landed on this method signature instead of phutil_microseconds_between(x, y) since I think it would be hard to remember if parameter order is start, end (chronological) or end, start (like arithmetic subtraction). It should be a little simpler to use in most cases, too.

Test Plan
$ cat test.php
<?php

require_once 'scripts/init/init-script.php';

$start = microtime(true);

sleep(1);

echo phutil_microseconds_since($start);
echo "\n";
$ php -f test.php
1001921

Diff Detail

Repository
rPHU libphutil
Branch
micros1
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/utils/utils.php:1317XHP45PHP Compatibility
Errorsrc/utils/utils.php:1317XHP45PHP Compatibility
Unit
Tests Passed
Build Status
Buildable 21118
Build 28709: Run Core Tests
Build 28708: arc lint + arc unit