Page MenuHomePhabricator

Fix an errant "switch ... continue"
ClosedPublic

Authored by epriestley on Nov 5 2018, 12:42 PM.
Tags
None
Referenced Files
F18826583: D19772.id47234.diff
Fri, Oct 24, 4:43 AM
F18822892: D19772.diff
Thu, Oct 23, 9:08 AM
F18798667: D19772.id47231.diff
Fri, Oct 17, 7:36 AM
F18698661: D19772.diff
Sat, Sep 27, 11:42 AM
F18568679: D19772.id47234.diff
Sep 10 2025, 12:21 AM
F18568676: D19772.id47231.diff
Sep 10 2025, 12:21 AM
F18509902: D19772.id.diff
Sep 5 2025, 3:40 AM
F18503439: D19772.diff
Sep 4 2025, 11:05 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-on-create-task/2062.

This construction has the same behavior as "switch ... break" but is unconventional. PHP 7.3 started warning about it because it's likely a mistake.

Test Plan

Created a task, edited a task owner. The new code is functionally identical to the old code.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Nov 5 2018, 3:32 PM
This revision was automatically updated to reflect the committed changes.