Page MenuHomePhabricator

Fix an errant "switch ... continue"
ClosedPublic

Authored by epriestley on Nov 5 2018, 12:42 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-on-create-task/2062.

This construction has the same behavior as "switch ... break" but is unconventional. PHP 7.3 started warning about it because it's likely a mistake.

Test Plan

Created a task, edited a task owner. The new code is functionally identical to the old code.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 5 2018, 12:42 PM
epriestley requested review of this revision.Nov 5 2018, 12:43 PM
amckinley accepted this revision.Nov 5 2018, 3:32 PM
This revision is now accepted and ready to land.Nov 5 2018, 3:32 PM
This revision was automatically updated to reflect the committed changes.