Differential D19772

Fix an errant "switch ... continue"
ClosedPublic
Actions

Authored by epriestley on Nov 5 2018, 12:42 PM.

Tags

None

Referenced Files

	F15442175: D19772.id47231.diff
	Wed, Mar 26, 9:57 PM

	F15418990: D19772.id47231.diff
	Fri, Mar 21, 2:49 AM

	F15407368: D19772.diff
	Tue, Mar 18, 5:15 PM

	F15345557: D19772.id47231.diff
	Mon, Mar 10, 11:23 AM

	F15344610: D19772.id47234.diff
	Mon, Mar 10, 5:44 AM

	Unknown Object (File)
	Feb 25 2025, 12:21 PM

	Unknown Object (File)
	Feb 21 2025, 3:27 PM

	Unknown Object (File)
	Feb 20 2025, 1:52 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPd2316e802568: Fix an errant "switch ... continue"

Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-on-create-task/2062.

This construction has the same behavior as "switch ... break" but is unconventional. PHP 7.3 started warning about it because it's likely a mistake.

Test Plan

Created a task, edited a task owner. The new code is functionally identical to the old code.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 5 2018, 12:42 PM

Harbormaster completed remote builds in B21080: Diff 47231.Nov 5 2018, 12:43 PM

epriestley requested review of this revision.Nov 5 2018, 12:43 PM

amckinley accepted this revision.Nov 5 2018, 3:32 PM

This revision is now accepted and ready to land.Nov 5 2018, 3:32 PM

Closed by commit rPd2316e802568: Fix an errant "switch ... continue" (authored by epriestley). · Explain WhyNov 5 2018, 6:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

editor/

ManiphestTransactionEditor.php

2 lines

Diff 47234

View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Fix an errant "switch ... continue"ClosedPublicActions