Page MenuHomePhabricator

Fix `packages(project)` to work properly and add it to "MailableFunctionDatasource"
ClosedPublic

Authored by epriestley on Oct 19 2018, 11:46 AM.

Details

Summary

Ref T13210. See PHI937. This function datasource isn't quite implemented correctly: it doesn't resolve package(project) properly, since the logic only handles users.

This blames back to D14013, where it looks like packages(..) was added mostly as a general nice-to-have as part of a larger modernization change.

Test Plan

Ran a packages(project) query in Differential, got accurate results (previously: no results).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Oct 19 2018, 11:46 AM
epriestley requested review of this revision.Oct 19 2018, 11:47 AM
amckinley accepted this revision.Oct 19 2018, 7:15 PM
This revision is now accepted and ready to land.Oct 19 2018, 7:15 PM
This revision was automatically updated to reflect the committed changes.