Page MenuHomePhabricator

Add a space after "View Inline" in mail to prevent double-click on the filename from selecting "Inline"
ClosedPublic

Authored by epriestley on Oct 10 2018, 7:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 2:35 PM
Unknown Object (File)
Sun, Mar 10, 2:13 AM
Unknown Object (File)
Sat, Mar 9, 3:38 AM
Unknown Object (File)
Feb 3 2024, 7:38 PM
Unknown Object (File)
Jan 16 2024, 12:19 AM
Unknown Object (File)
Jan 10 2024, 6:42 AM
Unknown Object (File)
Jan 5 2024, 1:33 PM
Unknown Object (File)
Dec 27 2023, 12:52 PM
Subscribers
None

Details

Summary

See PHI920. Ref T13210. Since the HTML is just:

<a>View Inline</a><span>filename.txt</span>

..double-clicking "filename.txt" in email selects "Inlinefilename.txt".

Add a space to stop this. At least in Safari, a space between the tags is not sufficient (perhaps because the parent is a <div>?). I couldn't find an authoritative-seeming source on what the rules for this actually are and adding a space here fixes the issue without changing the visual rendering, so just put it here.

Test Plan
  • Made an inline.
  • Used bin/mail show-outbound --id ... --dump-html to dump the HTML.
  • Double-clicked the filename.

Screen Shot 2018-10-10 at 12.40.39 PM.png (956×1 px, 131 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable