Page MenuHomePhabricator

Add a space after "View Inline" in mail to prevent double-click on the filename from selecting "Inline"
ClosedPublic

Authored by epriestley on Oct 10 2018, 7:44 PM.
Tags
None
Referenced Files
F14804684: D19742.diff
Sat, Jan 25, 5:44 PM
F14803510: D19742.diff
Sat, Jan 25, 3:41 PM
F14794998: D19742.id47171.diff
Sat, Jan 25, 2:28 AM
F14794997: D19742.id47165.diff
Sat, Jan 25, 2:28 AM
F14794996: D19742.id.diff
Sat, Jan 25, 2:28 AM
Unknown Object (File)
Sat, Jan 18, 7:42 AM
Unknown Object (File)
Sat, Jan 11, 4:48 PM
Unknown Object (File)
Fri, Dec 27, 7:08 PM
Subscribers
None

Details

Summary

See PHI920. Ref T13210. Since the HTML is just:

<a>View Inline</a><span>filename.txt</span>

..double-clicking "filename.txt" in email selects "Inlinefilename.txt".

Add a space to stop this. At least in Safari, a space between the tags is not sufficient (perhaps because the parent is a <div>?). I couldn't find an authoritative-seeming source on what the rules for this actually are and adding a space here fixes the issue without changing the visual rendering, so just put it here.

Test Plan
  • Made an inline.
  • Used bin/mail show-outbound --id ... --dump-html to dump the HTML.
  • Double-clicked the filename.

Screen Shot 2018-10-10 at 12.40.39 PM.png (956×1 px, 131 KB)

Diff Detail

Repository
rP Phabricator
Branch
select1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21008
Build 28538: Run Core Tests
Build 28537: arc lint + arc unit