Page MenuHomePhabricator

[Wilds] Make more test cases (mostly related to the phutil -> arcanist move) pass
ClosedPublic

Authored by epriestley on Sep 27 2018, 6:03 PM.

Details

Summary

Ref T13098. Makes some tests pass by updating 'phutil' to 'arcanist'. Skips some tests which won't pass for a while.

Also removes external test engines for now since they aren't realistically going to run for a while and they significantly complicate bootstrapping a set of passing tests out of arc unit.

Test Plan

Ran arc unit, saw fewer failures.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 20917
Build 28432: Run Core Tests

Event Timeline

epriestley created this revision.Sep 27 2018, 6:03 PM
epriestley requested review of this revision.Sep 27 2018, 6:03 PM
amckinley accepted this revision.Sep 27 2018, 8:22 PM
amckinley added inline comments.
src/__tests__/PhutilLibraryTestCase.php
14

I guess a skipped test is pretty visible, and grepping for "TOOLSETS" will find this too.

This revision is now accepted and ready to land.Sep 27 2018, 8:22 PM
epriestley marked an inline comment as done.Sep 27 2018, 9:30 PM
epriestley added inline comments.
src/__tests__/PhutilLibraryTestCase.php
14

Yeah. I've also made skipped tests more visible in the new code -- they're always summarized at the bottom of the output.

This revision was automatically updated to reflect the committed changes.