Paths

Table of Contentst

Differential D19714

[Wilds] Make more test cases (mostly related to the phutil -> arcanist move) pass
ClosedPublic
Actions

Authored by epriestley on Sep 27 2018, 6:03 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13098: Plans: Arcanist toolsets and extensions

Commits

rARCa3e29773df19: [Wilds] Make more test cases (mostly related to the phutil -> arcanist move)…

Summary

Ref T13098. Makes some tests pass by updating 'phutil' to 'arcanist'. Skips some tests which won't pass for a while.

Also removes external test engines for now since they aren't realistically going to run for a while and they significantly complicate bootstrapping a set of passing tests out of arc unit.

Test Plan

Ran arc unit, saw fewer failures.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 20917
Build 28432: Run Core Tests

Event Timeline

epriestley created this revision.Sep 27 2018, 6:03 PM

Herald added a subscriber: aurelijus. · View Herald TranscriptSep 27 2018, 6:03 PM

epriestley requested review of this revision.Sep 27 2018, 6:03 PM

Harbormaster failed remote builds in B20917: Diff 47108!Sep 27 2018, 6:03 PM

amckinley accepted this revision.Sep 27 2018, 8:22 PM

amckinley added inline comments.

src/__tests__/PhutilLibraryTestCase.php
14	I guess a skipped test is pretty visible, and grepping for "TOOLSETS" will find this too.

This revision is now accepted and ready to land.Sep 27 2018, 8:22 PM

epriestley marked an inline comment as done.Sep 27 2018, 9:30 PM

epriestley added inline comments.

src/__tests__/PhutilLibraryTestCase.php
14	Yeah. I've also made skipped tests more visible in the new code -- they're always summarized at the bottom of the output.

Closed by commit rARCa3e29773df19: [Wilds] Make more test cases (mostly related to the phutil -> arcanist move)… (authored by epriestley). · Explain WhyOct 1 2018, 11:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

test/

deferred_log.php

utils/

lock.php

src/

__phutil_library_map__.php

__tests__/

ArcanistLibraryTestCase.php

PhutilLibraryTestCase.php

4 lines

filesystem/

__tests__/

PhutilDeferredLogTestCase.php

4 lines

PhutilFileLockTestCase.php

4 lines

moduleutils/

__tests__/

PhutilModuleUtilsTestCase.php

2 lines

parser/

PhutilJSONParser.php

4 lines

calendar/

ics/

PhutilICSParser.php

2 lines

phage/

bootloader/

PhagePHPAgentBootloader.php

2 lines

search/

PhutilSearchStemmer.php

2 lines

unit/

engine/

CSharpToolsTestEngine.php

NoseTestEngine.php

PhpunitTestEngine.php

PytestTestEngine.php

XUnitTestEngine.php

__tests__/

PhpunitTestEngineTestCase.php

PhutilUnitTestEngineTestCase.php

3 lines

utils/

__tests__/

PhutilUtilsTestCase.php

1 line

	support/
	scripts/

	unit/
	test/

deferred_log.php

3 lines

	unit/
	utils/

lock.php

3 lines

Diff 47108

View Options

scripts/test/deferred_log.php

View Options

scripts/utils/lock.php

View Options

src/__phutil_library_map__.php

View Options

src/tests/ArcanistLibraryTestCase.php

View Options

src/tests/PhutilLibraryTestCase.php

View Options

src/filesystem/tests/PhutilDeferredLogTestCase.php

View Options

src/filesystem/tests/PhutilFileLockTestCase.php

View Options

src/moduleutils/tests/PhutilModuleUtilsTestCase.php

View Options

src/parser/PhutilJSONParser.php

View Options

src/parser/calendar/ics/PhutilICSParser.php

View Options

src/phage/bootloader/PhagePHPAgentBootloader.php

View Options

src/search/PhutilSearchStemmer.php

View Options

src/unit/engine/CSharpToolsTestEngine.php

View Options

src/unit/engine/NoseTestEngine.php

View Options

src/unit/engine/PhpunitTestEngine.php

View Options

src/unit/engine/PytestTestEngine.php

View Options

src/unit/engine/XUnitTestEngine.php

View Options

src/unit/engine/tests/PhpunitTestEngineTestCase.php

View Options

src/unit/engine/tests/PhutilUnitTestEngineTestCase.php

View Options

src/utils/tests/PhutilUtilsTestCase.php

View Options

support/unit/deferred_log.php

View Options

[Wilds] Make more test cases (mostly related to the phutil -> arcanist move) passClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47108

scripts/test/deferred_log.php

scripts/utils/lock.php

src/__phutil_library_map__.php

src/__tests__/ArcanistLibraryTestCase.php

src/__tests__/PhutilLibraryTestCase.php

src/filesystem/__tests__/PhutilDeferredLogTestCase.php

src/filesystem/__tests__/PhutilFileLockTestCase.php

src/moduleutils/__tests__/PhutilModuleUtilsTestCase.php

src/parser/PhutilJSONParser.php

src/parser/calendar/ics/PhutilICSParser.php

src/phage/bootloader/PhagePHPAgentBootloader.php

src/search/PhutilSearchStemmer.php

src/unit/engine/CSharpToolsTestEngine.php

src/unit/engine/NoseTestEngine.php

src/unit/engine/PhpunitTestEngine.php

src/unit/engine/PytestTestEngine.php

src/unit/engine/XUnitTestEngine.php

src/unit/engine/__tests__/PhpunitTestEngineTestCase.php

src/unit/engine/__tests__/PhutilUnitTestEngineTestCase.php

src/utils/__tests__/PhutilUtilsTestCase.php

support/unit/deferred_log.php

support/unit/lock.php

[Wilds] Make more test cases (mostly related to the phutil -> arcanist move) pass
ClosedPublic
Actions

Revision Contents
Changeset List

src/tests/ArcanistLibraryTestCase.php

src/tests/PhutilLibraryTestCase.php

src/filesystem/tests/PhutilDeferredLogTestCase.php

src/filesystem/tests/PhutilFileLockTestCase.php

src/moduleutils/tests/PhutilModuleUtilsTestCase.php

src/unit/engine/tests/PhpunitTestEngineTestCase.php

src/unit/engine/tests/PhutilUnitTestEngineTestCase.php

src/utils/tests/PhutilUtilsTestCase.php