Parameterize the repository read and write locks
ClosedPublic
Actions

Authored by epriestley on Sep 23 2018, 3:43 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13202: Plans: 2018 Week 38-40 Bonus Content

Commits

rP7db265cd5da5: Parameterize the repository read and write locks

Summary

Ref T13202. See PHI889. Update the read and write locks to the modern parameterized verison, which handles hashing/normalization and can store better logs.

This parameterized mode was added in D19173 and has been used successfully for some time, but not all locks have switched over to it yet.

Test Plan

Added an fprintf(STDERR, $full_name) to the lock code.
Pulled a repository.
Saw sensible lock name on stdout before "acquired read lock...".
Additional changes in this patch series will vet this more completely.

Diff Detail

Repository

rP Phabricator

Branch

lock1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20885
Build 28398: Run Core Tests
Build 28397: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 23 2018, 3:43 PM

Harbormaster completed remote builds in B20885: Diff 47071.Sep 23 2018, 3:44 PM

epriestley requested review of this revision.Sep 23 2018, 3:44 PM

amckinley accepted this revision.Sep 24 2018, 5:22 PM

This revision is now accepted and ready to land.Sep 24 2018, 5:22 PM

Closed by commit rP7db265cd5da5: Parameterize the repository read and write locks (authored by epriestley). · Explain WhySep 24 2018, 10:14 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13109: Improve cluster write feedback and write routing.Oct 17 2018, 10:01 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepositoryWorkingCopyVersion.php

16 lines

Diff 47071

View Options

src/applications/repository/storage/PhabricatorRepositoryWorkingCopyVersion.php

Parameterize the repository read and write locksClosedPublicActions