HomePhabricator

Parameterize the repository read and write locks

Description

Parameterize the repository read and write locks

Summary:
Ref T13202. See PHI889. Update the read and write locks to the modern parameterized verison, which handles hashing/normalization and can store better logs.

This parameterized mode was added in D19173 and has been used successfully for some time, but not all locks have switched over to it yet.

Test Plan:

  • Added an fprintf(STDERR, $full_name) to the lock code.
  • Pulled a repository.
  • Saw sensible lock name on stdout before "acquired read lock...".
  • Additional changes in this patch series will vet this more completely.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13202

Differential Revision: https://secure.phabricator.com/D19701

Details

Provenance
epriestleyAuthored on Sep 23 2018, 3:37 PM
epriestleyPushed on Sep 24 2018, 10:14 PM
Reviewer
amckinley
Differential Revision
D19701: Parameterize the repository read and write locks
Parents
rP3244324cb1ab: Fix comment box borders in timelines after Phriction commenting
Branches
Unknown
Tags
Unknown
Tasks
T13202: Plans: 2018 Week 38-40 Bonus Content
Build Status
Buildable 20887
Build 28401: Run Core Tests