Paths

Table of Contentst

Differential D19670

Remove "mailKey" from "PhabricatorRepositoryCommit"
ClosedPublic
Actions

Authored by epriestley on Sep 14 2018, 1:27 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13065: Move storage for `mailKey` to the Mail application
T13197: 2018 Week 37 Bonus Content

Commits

rP40d5d5c9848e: Remove "mailKey" from "PhabricatorRepositoryCommit"

Summary

Ref T13197. Ref T13065. This continues the gradual purge of dedicated "mailKey" columns in favor of shared infrastructure.

Test Plan

Ran migration.
Visually inspected database.
Grepped for mailKey.
Added some comments, saw the daemons generate corresponding mail.

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 14 2018, 1:27 PM

Owners added a subscriber: Restricted Owners Package.Sep 14 2018, 1:27 PM

Harbormaster completed remote builds in B20820: Diff 47009.Sep 14 2018, 1:29 PM

epriestley requested review of this revision.Sep 14 2018, 1:29 PM

amckinley accepted this revision.Sep 14 2018, 5:59 PM

This revision is now accepted and ready to land.Sep 14 2018, 5:59 PM

Closed by commit rP40d5d5c9848e: Remove "mailKey" from "PhabricatorRepositoryCommit" (authored by epriestley). · Explain WhySep 15 2018, 2:54 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D19922: Remove the onboard "mailKey" from Pholio Mocks.Dec 20 2018, 7:56 PM

epriestley mentioned this in rP1e2bc7775bc4: Remove the onboard "mailKey" from Pholio Mocks.Dec 20 2018, 11:30 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20180914.audit.01.mailkey.php

26 lines

20180914.audit.02.rmkey.sql

2 lines

src/

applications/

repository/

storage/

PhabricatorRepositoryCommit.php

10 lines

Diff 47023

View Options

resources/sql/autopatches/20180914.audit.01.mailkey.php

View Options

resources/sql/autopatches/20180914.audit.02.rmkey.sql

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Remove "mailKey" from "PhabricatorRepositoryCommit"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47023

resources/sql/autopatches/20180914.audit.01.mailkey.php

resources/sql/autopatches/20180914.audit.02.rmkey.sql

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Remove "mailKey" from "PhabricatorRepositoryCommit"
ClosedPublic
Actions

Revision Contents
Changeset List