Page MenuHomePhabricator

In Differential: when the file tree is enabled, default to the "History" tab instead of "Files"
ClosedPublic

Authored by epriestley on Aug 24 2018, 5:27 PM.
Tags
None
Referenced Files
F13151701: D19601.diff
Sat, May 4, 6:45 PM
Unknown Object (File)
Wed, May 1, 12:07 AM
Unknown Object (File)
Mon, Apr 29, 6:25 AM
Unknown Object (File)
Sat, Apr 27, 3:24 AM
Unknown Object (File)
Fri, Apr 19, 7:52 PM
Unknown Object (File)
Thu, Apr 11, 8:58 AM
Unknown Object (File)
Apr 4 2024, 1:24 PM
Unknown Object (File)
Mar 5 2024, 10:20 PM
Subscribers
None

Details

Summary

Ref T13187. See PHI811. If the file tree is enabled and visible, set the default tab to "History".

  • This is a bit magic.
  • It won't work entirely on mobile (we can't tell that you're on mobile on the server, so we'll pick the "History" tab even though the file tree isn't actually visible on your device).
  • There's no corresponding logic in Diffusion. Diffusion doesn't have the same tab layout, but this makes things somewhat inconsistent.

So I don't love this, but we can try it and see if it's confusing or helpful on the balance.

Test Plan

With filetree on and off, reloaded revisions. Saw appropriate tab selected by default.

Diff Detail

Repository
rP Phabricator
Branch
filetree1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20663
Build 28083: Run Core Tests
Build 28082: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2018, 5:29 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.