Page MenuHomePhabricator

In Differential: when the file tree is enabled, default to the "History" tab instead of "Files"
ClosedPublic

Authored by epriestley on Aug 24 2018, 5:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 11 2025, 2:05 PM
Unknown Object (File)
May 10 2025, 8:49 AM
Unknown Object (File)
May 2 2025, 7:57 PM
Unknown Object (File)
Apr 30 2025, 4:02 AM
Unknown Object (File)
Apr 28 2025, 7:07 PM
Unknown Object (File)
Apr 22 2025, 6:25 AM
Unknown Object (File)
Mar 30 2025, 8:40 PM
Unknown Object (File)
Mar 28 2025, 11:04 PM
Subscribers
None

Details

Summary

Ref T13187. See PHI811. If the file tree is enabled and visible, set the default tab to "History".

  • This is a bit magic.
  • It won't work entirely on mobile (we can't tell that you're on mobile on the server, so we'll pick the "History" tab even though the file tree isn't actually visible on your device).
  • There's no corresponding logic in Diffusion. Diffusion doesn't have the same tab layout, but this makes things somewhat inconsistent.

So I don't love this, but we can try it and see if it's confusing or helpful on the balance.

Test Plan

With filetree on and off, reloaded revisions. Saw appropriate tab selected by default.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2018, 5:29 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.