Enrich "priority" transactions in Maniphest for "transaction.search"
ClosedPublic
Actions

Authored by epriestley on Aug 24 2018, 5:03 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13187: Plans: 2018 Week 34 Bonus Content

Commits

rPb6fa009cf00a: Enrich "priority" transactions in Maniphest for "transaction.search"

Summary

Ref T13187. See https://discourse.phabricator-community.org/t/task-priority-change-info-missing-in-firehose-webhook/1832/2. We can reasonably enrich these transactions.

Since priorities don't have unique authorative string identifiers, I've mostly mimicked the maniphest.search structure.

Test Plan

Called transaction.search on tasks which were: created normally, created with a priority change, saw a priority change after creation. All the output looked useful and sensible.

Diff Detail

Repository

rP Phabricator

Branch

priority

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20658
Build 28076: Run Core Tests
Build 28075: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 24 2018, 5:03 PM

Harbormaster completed remote builds in B20658: Diff 46857.Aug 24 2018, 5:04 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2018, 5:04 PM

epriestley requested review of this revision.

Closed by commit rPb6fa009cf00a: Enrich "priority" transactions in Maniphest for "transaction.search" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

xaction/

ManiphestTaskPriorityTransaction.php

29 lines

Diff 46857

View Options

src/applications/maniphest/xaction/ManiphestTaskPriorityTransaction.php

Enrich "priority" transactions in Maniphest for "transaction.search"ClosedPublicActions