Page MenuHomePhabricator

Support Mercurial "protocaps" wire command
ClosedPublic

Authored by epriestley on Aug 23 2018, 10:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 9:23 AM
Unknown Object (File)
Mon, Apr 29, 8:10 AM
Unknown Object (File)
Thu, Apr 25, 3:01 AM
Unknown Object (File)
Mar 29 2024, 2:41 PM
Unknown Object (File)
Mar 13 2024, 3:51 PM
Unknown Object (File)
Jan 9 2024, 12:09 PM
Unknown Object (File)
Dec 22 2023, 12:14 AM
Unknown Object (File)
Dec 14 2023, 9:34 PM
Subscribers
None

Details

Summary

Ref T13187. See PHI834. Mercurial has somewhat-recently (changeset is from Jan 2018) introduced a new "protocaps" command, that appears in Mercurial 4.7 and possibly before then.

We must explicitly enumerate all protocol commands because you can't decode the protocol without knowing how many arguments the command expects, so enumerate it.

(Also fix an issue where the related error message had an extra apostrophe.)

Test Plan
  • Ran hg clone ... with client and server on Mercurial 4.7.
  • Before: fatal on unknown "protocaps" command.
  • Midway: better typography in error message.
  • After: clean clone.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 23 2018, 10:04 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.