Ignore PHP types for "needs" symbols
ClosedPublic
Actions

Authored by joshuaspence on Aug 15 2018, 2:16 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUc309c5d93354: Ignore PHP types for "needs" symbols

Summary

I maintain a Phabricator library which supports PHP 7, but I can't use PHP 7 types because this causes "unknown class/interface" linter warnings. Ignore PHP built-in types, similar to D18151.

Test Plan

Ran scripts/phutil_symbols.php on the following file:

<?php

function x(array $a, bool $b, float $f, int $i, string $s, iterable $ii, object $o): void {}

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20621
Build 28024: Run Core Tests
Build 28023: arc lint + arc unit

Event Timeline

joshuaspence created this revision.Aug 15 2018, 2:16 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 15 2018, 2:16 AM

Harbormaster completed remote builds in B20621: Diff 46822.Aug 15 2018, 2:17 AM

joshuaspence requested review of this revision.Aug 15 2018, 2:17 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 15 2018, 2:17 AM

epriestley accepted this revision.Aug 15 2018, 5:00 PM

epriestley added inline comments.

scripts/phutil_symbols.php
550	Not you, but maybe fix `it s` -> `it's` if you still have this file handy.

This revision is now accepted and ready to land.Aug 15 2018, 5:00 PM

Fix someone else's mistakes

Harbormaster completed remote builds in B20626: Diff 46827.Aug 15 2018, 8:45 PM

Closed by commit rPHUc309c5d93354: Ignore PHP types for "needs" symbols (authored by joshuaspence). · Explain WhyAug 15 2018, 8:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

phutil_symbols.php

9 lines

Diff 46822

View Options

scripts/phutil_symbols.php

Ignore PHP types for "needs" symbolsClosedPublicActions