Page MenuHomePhabricator

Don't warn about use of "Throwable" under PHP5
ClosedPublic

Authored by epriestley on Jun 23 2017, 4:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 7, 8:32 PM
Unknown Object (File)
Apr 26 2025, 8:56 AM
Unknown Object (File)
Apr 21 2025, 4:59 PM
Unknown Object (File)
Apr 21 2025, 1:55 PM
Unknown Object (File)
Apr 21 2025, 6:18 AM
Unknown Object (File)
Apr 20 2025, 7:08 PM
Unknown Object (File)
Apr 18 2025, 8:37 PM
Unknown Object (File)
Apr 17 2025, 9:43 PM
Subscribers
None

Details

Summary

Ref T12855. Throwable does not exist in PHP5, but can be used safely in this construct, at a minimum:

} catch (Exception $ex) {
} catch (Throwable $ex) {

We could heavily overachive here by trying to make sure that uses of Throwable were all safe, but I suspect we'll end up with about 15 uses and never really have problems with this. Until this is a real problem, just stop the analyzer from complaining about Throwable and Error.

Test Plan
  • Changed Throwable to Throwablez.
  • Ran arc lint.
  • Got a lint error.
  • Added Throwablez to whitelist.
  • (Prodded some caches.)
  • No more lint error.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable