Page MenuHomePhabricator

Fix an issue with error handling when no mailers are available
ClosedPublic

Authored by epriestley on Aug 13 2018, 4:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 4:54 PM
Unknown Object (File)
Wed, Jan 29, 4:54 PM
Unknown Object (File)
Wed, Jan 29, 3:02 PM
Unknown Object (File)
Tue, Jan 28, 4:00 AM
Unknown Object (File)
Sun, Jan 26, 3:40 PM
Unknown Object (File)
Sat, Jan 25, 1:53 AM
Unknown Object (File)
Sat, Jan 25, 1:53 AM
Unknown Object (File)
Sat, Jan 25, 1:53 AM
Subscribers
None

Details

Summary

Ref T13164. See PHI785. See D19546. I think I didn't test the updated error messaging here entirely properly, since I have some tasks in queue which error out here ("Missing argument 1 to newMailers(...)").

This is an error condition already, but we want to get through this call so we can raise a tailored message.

Test Plan

Tasks which errored out here now succeed. This condition is only reachable if you misconfigure things in the first place.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable