Page MenuHomePhabricator

Fix an issue with error handling when no mailers are available
ClosedPublic

Authored by epriestley on Aug 13 2018, 4:29 PM.
Tags
None
Referenced Files
F17943967: D19572.id46797.diff
Thu, Jul 31, 9:09 AM
F17943966: D19572.id46793.diff
Thu, Jul 31, 9:08 AM
F17943665: D19572.id.diff
Thu, Jul 31, 8:36 AM
F17833484: D19572.diff
Sat, Jul 26, 1:37 PM
Unknown Object (File)
Jun 3 2025, 11:23 AM
Unknown Object (File)
May 28 2025, 11:35 AM
Unknown Object (File)
May 26 2025, 9:54 AM
Unknown Object (File)
Apr 27 2025, 8:13 AM
Subscribers
None

Details

Summary

Ref T13164. See PHI785. See D19546. I think I didn't test the updated error messaging here entirely properly, since I have some tasks in queue which error out here ("Missing argument 1 to newMailers(...)").

This is an error condition already, but we want to get through this call so we can raise a tailored message.

Test Plan

Tasks which errored out here now succeed. This condition is only reachable if you misconfigure things in the first place.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable