Page MenuHomePhabricator

In Differential standalone views, disable some keyboard shortcuts which don't work
ClosedPublic

Authored by epriestley on Aug 13 2018, 3:48 PM.
Tags
None
Referenced Files
F17397876: D19571.diff
Sun, Jun 29, 6:03 AM
Unknown Object (File)
May 26 2025, 8:13 PM
Unknown Object (File)
May 25 2025, 7:19 AM
Unknown Object (File)
May 10 2025, 12:44 PM
Unknown Object (File)
May 7 2025, 9:05 AM
Unknown Object (File)
Apr 30 2025, 10:59 AM
Unknown Object (File)
Apr 27 2025, 4:21 AM
Unknown Object (File)
Apr 26 2025, 7:36 PM
Subscribers
None

Details

Summary

Ref T13164. See PHI693. In Differential, you can View OptionsView Standalone to get a standalone view of a single changeset. You can also arrive here via the big changeset list for revisions affecting a huge number of files.

We currently suggest that all the keyboard shortcuts work, but some do not. In particular, the "Next File" and "Previous File" keyboard shortcuts (and some similar shortcuts) do not work. In the main view, the next/previous files are on the same page. In the standalone view, we'd need to actually change the URI.

Ideally, we should do this (and, e.g., put prev/next links on the page). As a first step toward that, hide the nonfunctional shortcuts to stop users from being misled.

Test Plan
  • Viewed a revision in normal and standalone views.
  • No changes in normal view, and all keys still work ("N", "P", etc).
  • In standalone view, "?" no longer shows nonfunctional key commands.

Diff Detail

Repository
rP Phabricator
Branch
key1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20593
Build 27975: Run Core Tests
Build 27974: arc lint + arc unit