Page MenuHomePhabricator

In Differential standalone views, disable some keyboard shortcuts which don't work
ClosedPublic

Authored by epriestley on Aug 13 2018, 3:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 4:24 PM
Unknown Object (File)
Feb 15 2024, 8:17 PM
Unknown Object (File)
Jan 20 2024, 5:40 PM
Unknown Object (File)
Jan 16 2024, 5:38 PM
Unknown Object (File)
Jan 12 2024, 5:26 PM
Unknown Object (File)
Jan 8 2024, 4:29 PM
Unknown Object (File)
Jan 4 2024, 5:05 PM
Unknown Object (File)
Dec 31 2023, 7:19 PM
Subscribers
None

Details

Summary

Ref T13164. See PHI693. In Differential, you can View OptionsView Standalone to get a standalone view of a single changeset. You can also arrive here via the big changeset list for revisions affecting a huge number of files.

We currently suggest that all the keyboard shortcuts work, but some do not. In particular, the "Next File" and "Previous File" keyboard shortcuts (and some similar shortcuts) do not work. In the main view, the next/previous files are on the same page. In the standalone view, we'd need to actually change the URI.

Ideally, we should do this (and, e.g., put prev/next links on the page). As a first step toward that, hide the nonfunctional shortcuts to stop users from being misled.

Test Plan
  • Viewed a revision in normal and standalone views.
  • No changes in normal view, and all keys still work ("N", "P", etc).
  • In standalone view, "?" no longer shows nonfunctional key commands.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable