Paths

Table of Contentst

Differential D19569

Improve compatibility of "Config > Cache Status" across APCu versions
ClosedPublic
Actions

Authored by epriestley on Aug 8 2018, 6:30 PM.

Tags

None

Referenced Files

	F13176958: D19569.diff
	Wed, May 8, 6:20 PM

	Unknown Object (File)
	Mon, May 6, 2:14 AM

	Unknown Object (File)
	Sat, May 4, 1:28 PM

	Unknown Object (File)
	Thu, May 2, 1:58 AM

	Unknown Object (File)
	Wed, May 1, 9:14 PM

	Unknown Object (File)
	Thu, Apr 25, 5:17 PM

	Unknown Object (File)
	Mon, Apr 22, 1:24 AM

	Unknown Object (File)
	Apr 2 2024, 5:19 PM

View All 90 Files

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13164: Plans: 2018 Week 31 - 33 Bonus Content

Commits

rPdf31405d64a4: Improve compatibility of "Config > Cache Status" across APCu versions

Summary

Ref T13164. See PHI790. Older versions of APCu reported cache keys as "key" from apcu_cache_info(). APC and newer APCu report it as "info".

Check both indexes for compatibility.

Test Plan

Locally, with newer APCu, saw no behavioral change.
Will double check on admin, which has an older APCu with the "key" behavior.
(I hunted this down by dumping apcu_cache_info() on admin to see what was going on.)

Diff Detail

Repository

Branch

apc1

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/applications/cache/spec/PhabricatorDataCacheSpec.php:92	XHP45	PHP Compatibility

Unit

Tests Passed

Build Status

Buildable 20583
Build 27960: Run Core Tests
Build 27959: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 8 2018, 6:30 PM

epriestley added inline comments.Aug 8 2018, 6:31 PM

src/applications/cache/spec/PhabricatorDataCacheSpec.php
118–122	Previously, we would send `<unknown-key>` into `getKeyPattern()`, which would turn it into `<other-namespace>` most of the time, making the problem less obvious. I tweaked this so we retain `<unknown-key>`.

Harbormaster completed remote builds in B20583: Diff 46781.Aug 8 2018, 6:31 PM

epriestley requested review of this revision.Aug 8 2018, 6:31 PM

amckinley accepted this revision.Aug 8 2018, 10:04 PM

This revision is now accepted and ready to land.Aug 8 2018, 10:04 PM

Closed by commit rPdf31405d64a4: Improve compatibility of "Config > Cache Status" across APCu versions (authored by epriestley). · Explain WhyAug 8 2018, 10:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

cache/

spec/

PhabricatorDataCacheSpec.php

17 lines

Diff 46781

src/applications/cache/spec/PhabricatorDataCacheSpec.php

Loading...