Page MenuHomePhabricator

Improve compatibility of "Config > Cache Status" across APCu versions
ClosedPublic

Authored by epriestley on Aug 8 2018, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 24, 1:51 PM
Unknown Object (File)
Tue, Jul 23, 4:39 AM
Unknown Object (File)
Sat, Jul 20, 2:01 PM
Unknown Object (File)
Tue, Jul 16, 4:38 AM
Unknown Object (File)
Thu, Jul 11, 5:18 PM
Unknown Object (File)
Wed, Jul 10, 5:55 AM
Unknown Object (File)
Fri, Jul 5, 10:18 PM
Unknown Object (File)
Tue, Jul 2, 5:36 AM
Subscribers
None

Details

Summary

Ref T13164. See PHI790. Older versions of APCu reported cache keys as "key" from apcu_cache_info(). APC and newer APCu report it as "info".

Check both indexes for compatibility.

Test Plan
  • Locally, with newer APCu, saw no behavioral change.
  • Will double check on admin, which has an older APCu with the "key" behavior.
  • (I hunted this down by dumping apcu_cache_info() on admin to see what was going on.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/cache/spec/PhabricatorDataCacheSpec.php
118–122

Previously, we would send <unknown-key> into getKeyPattern(), which would turn it into <other-namespace> most of the time, making the problem less obvious. I tweaked this so we retain <unknown-key>.

This revision is now accepted and ready to land.Aug 8 2018, 10:04 PM
This revision was automatically updated to reflect the committed changes.