Page MenuHomePhabricator

Add an "--as" flag to "bin/conduit call ..." to improve flexibility and ease of profiling
ClosedPublic

Authored by epriestley on Aug 8 2018, 4:10 PM.
Tags
None
Referenced Files
F17948055: D19566.id46776.diff
Thu, Jul 31, 7:56 PM
F17946200: D19566.id.diff
Thu, Jul 31, 1:46 PM
F17931858: D19566.diff
Wed, Jul 30, 7:30 PM
F17668789: D19566.id46776.diff
Sat, Jul 12, 11:26 PM
F17635136: D19566.diff
Fri, Jul 11, 12:52 AM
Unknown Object (File)
Jul 1 2025, 6:04 PM
Unknown Object (File)
Jun 18 2025, 9:57 AM
Unknown Object (File)
Jun 18 2025, 3:31 AM
Subscribers
None

Details

Summary

Ref T13164. In PHI801, an install reported a particular slow Conduit method call.

Conduit calls aren't easily profilable with normal tools (for example, arc call-conduit --xprofile ... gives you a profile of the client). They can be profiled most easily with bin/conduit call ... --xprofile.

However, bin/conduit call currently doesn't let you pick a user to execute the command on behalf of, so it's not terribly useful for profiling *.edit-style methods which do a write: these need a real acting user.

Test Plan

Ran bin/conduit call --method user.whoami --as epriestley ... with valid, invalid, and no acting users.

$ echo '{}' | ./bin/conduit call --method user.whoami --as epriestley --input -
Reading input from stdin...
{
  "result": {
    "phid": "PHID-USER-icyixzkx3f4ttv67avbn",
    "userName": "epriestley",
    "realName": "Evan Priestley",
...

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable