Page MenuHomePhabricator

Stop indexing the chunk data objects for large Files stored in multiple chunks
ClosedPublic

Authored by epriestley on Aug 3 2018, 9:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 5:39 AM
Unknown Object (File)
Sat, Dec 14, 11:21 AM
Unknown Object (File)
Fri, Dec 6, 6:37 AM
Unknown Object (File)
Tue, Dec 3, 9:51 PM
Unknown Object (File)
Mon, Nov 25, 6:58 AM
Unknown Object (File)
Oct 23 2024, 4:32 AM
Unknown Object (File)
Oct 13 2024, 1:44 AM
Unknown Object (File)
Oct 9 2024, 9:48 AM
Subscribers
None

Details

Summary

Ref T13164. See PHI766. Currently, when file data is stored in small chunks, we submit each chunk to the indexing engine.

However, chunks are never surfaced directly and can never be found via any search/query, so this work is pointless. Just skip it.

(It would be nice to do this a little more formally on IndexableInterface or similar as isThisAnIndexableObject(), but we'd have to add like a million empty "yes, index this always" methods to do that, and it seems unlikely that we'll end up with too many other objects like these.)

Test Plan
  • Ran bin/harbormaster rebuild-log --id ... --force before and after change, saw about 200 fewer queries after the change.
  • Uploaded a uniquely named file and searched for it to make sure I didn't break that.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable