Raise a tailored error when calling "transaction.search" with empty "phids" constraint
ClosedPublic
Actions

Authored by epriestley on Aug 3 2018, 8:04 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13164: Plans: 2018 Week 31 - 33 Bonus Content

Commits

rP5839a54b604d: Raise a tailored error when calling "transaction.search" with empty "phids"…

Summary

Ref T13164. See PHI725. For real "*.search" methods, parameters get validated and you get an error if you use an empty list as a constraint.

Since "transaction.search" isn't really a normal "*.search" method, it doesn't benefit from this. Just do the check manually for now.

Test Plan

Made transaction.search calls with no constraints (got results); a valid costraint (got fewer results); and an invalid empty constraint (got an exception).

Diff Detail

Repository

rP Phabricator

Branch

xaction1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20565
Build 27935: Run Core Tests
Build 27934: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 3 2018, 8:04 PM

Harbormaster completed remote builds in B20565: Diff 46766.Aug 3 2018, 8:05 PM

epriestley requested review of this revision.Aug 3 2018, 8:05 PM

amckinley accepted this revision.Aug 3 2018, 8:33 PM

This revision is now accepted and ready to land.Aug 3 2018, 8:33 PM

Closed by commit rP5839a54b604d: Raise a tailored error when calling "transaction.search" with empty "phids"… (authored by epriestley). · Explain WhyAug 3 2018, 9:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

conduit/

TransactionSearchConduitAPIMethod.php

8 lines

Diff 46766

View Options

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

Raise a tailored error when calling "transaction.search" with empty "phids" constraintClosedPublicActions