Page MenuHomePhabricator

Raise a tailored error when calling "transaction.search" with empty "phids" constraint
ClosedPublic

Authored by epriestley on Aug 3 2018, 8:04 PM.
Tags
None
Referenced Files
F18218663: D19562.id46766.diff
Tue, Aug 19, 10:27 AM
F18200560: D19562.id.diff
Mon, Aug 18, 5:37 AM
F18194993: D19562.diff
Sun, Aug 17, 1:16 PM
F18090936: D19562.id46769.diff
Wed, Aug 6, 6:11 PM
Unknown Object (File)
Jun 5 2025, 10:15 PM
Unknown Object (File)
Jun 5 2025, 10:54 AM
Unknown Object (File)
Jun 4 2025, 5:18 AM
Unknown Object (File)
Jun 3 2025, 1:13 PM
Subscribers
None

Details

Summary

Ref T13164. See PHI725. For real "*.search" methods, parameters get validated and you get an error if you use an empty list as a constraint.

Since "transaction.search" isn't really a normal "*.search" method, it doesn't benefit from this. Just do the check manually for now.

Test Plan

Made transaction.search calls with no constraints (got results); a valid costraint (got fewer results); and an invalid empty constraint (got an exception).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable