Page MenuHomePhabricator

Raise a tailored error when calling "transaction.search" with empty "phids" constraint
ClosedPublic

Authored by epriestley on Aug 3 2018, 8:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 2:41 PM
Unknown Object (File)
Dec 22 2023, 8:10 AM
Unknown Object (File)
Dec 22 2023, 12:08 AM
Unknown Object (File)
Dec 20 2023, 9:47 PM
Unknown Object (File)
Dec 19 2023, 7:47 PM
Unknown Object (File)
Dec 15 2023, 4:45 PM
Unknown Object (File)
Nov 30 2023, 1:37 AM
Unknown Object (File)
Nov 25 2023, 7:41 PM
Subscribers
None

Details

Summary

Ref T13164. See PHI725. For real "*.search" methods, parameters get validated and you get an error if you use an empty list as a constraint.

Since "transaction.search" isn't really a normal "*.search" method, it doesn't benefit from this. Just do the check manually for now.

Test Plan

Made transaction.search calls with no constraints (got results); a valid costraint (got fewer results); and an invalid empty constraint (got an exception).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable