Page MenuHomePhabricator

Raise a tailored error when calling "transaction.search" with empty "phids" constraint
ClosedPublic

Authored by epriestley on Aug 3 2018, 8:04 PM.
Tags
None
Referenced Files
F15542039: D19562.id46769.diff
Fri, Apr 25, 3:16 PM
F15528308: D19562.id.diff
Tue, Apr 22, 10:17 AM
F15482895: D19562.id46769.diff
Wed, Apr 9, 8:34 AM
F15473658: D19562.diff
Sun, Apr 6, 12:29 AM
F15456785: D19562.id46766.diff
Sun, Mar 30, 12:11 PM
F15439209: D19562.id.diff
Mar 26 2025, 6:21 AM
F15431936: D19562.diff
Mar 24 2025, 3:25 PM
F15413504: D19562.id.diff
Mar 19 2025, 7:17 PM
Subscribers
None

Details

Summary

Ref T13164. See PHI725. For real "*.search" methods, parameters get validated and you get an error if you use an empty list as a constraint.

Since "transaction.search" isn't really a normal "*.search" method, it doesn't benefit from this. Just do the check manually for now.

Test Plan

Made transaction.search calls with no constraints (got results); a valid costraint (got fewer results); and an invalid empty constraint (got an exception).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable