Page MenuHomePhabricator

Add Spaces support to Phriction
ClosedPublic

Authored by epriestley on Jul 30 2018, 11:32 PM.

Details

Summary

Ref T13164. See PHI774. Fixes T12435.

Since Phriction is hierarchical, there isn't a super strong motivation to support Spaces: you can generally set policies on a small number of documents to get the desired effective policy behavior.

However, it still improves consistency and there's no reason not to support Spaces. In the case where you have some moderately weird/complex policy on one or more Spaces, using Spaces to define the policy behavior can make things a bit simpler and easier to understand.

This probably doesn't actually fix whatever the root problem in T12435 was (complicated, non-hierarchical access policies?). See also a bunch of discussion in T12442. So we might end up going beyond this to address other use cases, but I think this is reasonable regardless.

Test Plan

Created and edited Phriction documents and shifted them between Spaces. Searched by Space, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jul 30 2018, 11:32 PM
This revision is now accepted and ready to land.Jul 31 2018, 4:45 PM
This revision was automatically updated to reflect the committed changes.